jenkins-bot has submitted this change and it was merged.
Change subject: Resized Text area in ReplaceText extension
......................................................................
Resized Text area in ReplaceText extension
Given these fields 100% width and, say, 25 or more rows
for easy editing of text. This is important due to the
risk of overlooking mistakes if all the text is not visible.
patch courtsey: Pranav Ravichandran
Bug: 32894
Change-Id: I08f36d5c581ea4b0429f88899830ea0868407435
---
M SpecialReplaceText.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/SpecialReplaceText.php b/SpecialReplaceText.php
index 70939a8..b61e32b 100644
--- a/SpecialReplaceText.php
+++ b/SpecialReplaceText.php
@@ -275,11 +275,11 @@
// 'width: auto' style is needed to override MediaWiki's
// normal 'width: 100%', which causes the textarea to get
// zero width in IE
- $out->addHTML( Xml::textarea( 'target', $this->target, 50, 2,
array( 'style' => 'width: auto;' ) ) );
+ $out->addHTML( Xml::textarea( 'target', $this->target, 125, 25,
array( 'style' => 'width: auto;' ) ) );
$out->addHTML( '</td></tr><tr><td style="vertical-align:
top;">' );
$out->addWikiMsg( 'replacetext_replacementtext' );
$out->addHTML( '</td><td>' );
- $out->addHTML( Xml::textarea( 'replacement',
$this->replacement, 50, 2, array( 'style' => 'width: auto;' ) ) );
+ $out->addHTML( Xml::textarea( 'replacement',
$this->replacement, 125, 25, array( 'style' => 'width: auto;' ) ) );
$out->addHTML( '</td></tr></table>' );
$out->addHTML( Xml::tags( 'p', null,
Xml::checkLabel(
--
To view, visit https://gerrit.wikimedia.org/r/103101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08f36d5c581ea4b0429f88899830ea0868407435
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReplaceText
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>
Gerrit-Reviewer: MarkAHershberger <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
