UltrasonicNXT has uploaded a new change for review.
https://gerrit.wikimedia.org/r/103384
Change subject: Fix bug with getDupeWarning
......................................................................
Fix bug with getDupeWarning
The function was trying to overwrite its parent, but was trying to be
static, when the parent is dynamic. This produces PHP errors, preventing
the use of MultiUpload and Special:SpecialPages. Fixed by not declaring
the function as static
Change-Id: Ib2a6004ee009bee3d72008e1c41f7985199fe27c
---
M MultiUpload.body.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultiUpload
refs/changes/84/103384/1
diff --git a/MultiUpload.body.php b/MultiUpload.body.php
index cb2e7a6..6ff8a6c 100644
--- a/MultiUpload.body.php
+++ b/MultiUpload.body.php
@@ -351,7 +351,7 @@
* Construct a warning and a gallery from an array of duplicate files.
* Override because the original doesn't say which file is a dupe
*/
- public static function getDupeWarning( $dupes, $dupeTitle = null ) {
+ public function getDupeWarning( $dupes, $dupeTitle = null ) {
$result = parent::getDupeWarning( $dupes );
return preg_replace( '@<li>@', "<li>{$dupeTitle->getText()}",
$result );
}
--
To view, visit https://gerrit.wikimedia.org/r/103384
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2a6004ee009bee3d72008e1c41f7985199fe27c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultiUpload
Gerrit-Branch: master
Gerrit-Owner: UltrasonicNXT <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
