Ottomata has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/103585


Change subject: Moving jmx port variables into defaults.pp
......................................................................

Moving jmx port variables into defaults.pp

Change-Id: I3dfa846f3c3db8994baab32eba4e3a7358bb35ac
---
M manifests/hadoop.pp
M manifests/hadoop/defaults.pp
2 files changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/cdh4 
refs/changes/85/103585/1

diff --git a/manifests/hadoop.pp b/manifests/hadoop.pp
index a149a29..0323a43 100644
--- a/manifests/hadoop.pp
+++ b/manifests/hadoop.pp
@@ -110,14 +110,6 @@
     $net_topology_script_template                = 
$::cdh4::hadoop::defaults::net_topology_script_template
 ) inherits cdh4::hadoop::defaults
 {
-    # JMX Ports
-    $namenode_jmxremote_port           = 9980
-    $datanode_jmxremote_port           = 9981
-    $secondary_namenode_jmxremote_port = 9982
-    $resourcemanager_jmxremote_port    = 9983
-    $nodemanager_jmxremote_port        = 9984
-    $proxyserver_jmxremote_port        = 9985
-
     # If $dfs_name_dir is a list, this will be the
     # first entry in the list.  Else just $dfs_name_dir.
     # This used in a couple of execs throughout this module.
diff --git a/manifests/hadoop/defaults.pp b/manifests/hadoop/defaults.pp
index 304c708..ec7d131 100644
--- a/manifests/hadoop/defaults.pp
+++ b/manifests/hadoop/defaults.pp
@@ -37,4 +37,13 @@
     $use_yarn                                 = true
     $ganglia_hosts                            = undef
     $net_topology_script_template             = undef
+
+
+    # JMX Ports (These are not currently configurable)
+    $namenode_jmxremote_port           = 9980
+    $datanode_jmxremote_port           = 9981
+    $secondary_namenode_jmxremote_port = 9982
+    $resourcemanager_jmxremote_port    = 9983
+    $nodemanager_jmxremote_port        = 9984
+    $proxyserver_jmxremote_port        = 9985
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/103585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dfa846f3c3db8994baab32eba4e3a7358bb35ac
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/cdh4
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to