Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/103874
Change subject: Declare visibility for class properties in DatabaseSqlite
......................................................................
Declare visibility for class properties in DatabaseSqlite
$mName appears to be unused.
Change-Id: Id9ef59cf070e379413d16a8d4456fd93df296442
---
M includes/db/DatabaseSqlite.php
1 file changed, 14 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/74/103874/1
diff --git a/includes/db/DatabaseSqlite.php b/includes/db/DatabaseSqlite.php
index 89f0818..ea35391 100644
--- a/includes/db/DatabaseSqlite.php
+++ b/includes/db/DatabaseSqlite.php
@@ -26,16 +26,25 @@
* @ingroup Database
*/
class DatabaseSqlite extends DatabaseBase {
+ /** @var bool Whether full text is enabled */
private static $fulltextEnabled = null;
- var $mAffectedRows;
- var $mLastResult;
- var $mDatabaseFile;
- var $mName;
+ /** @var string File name for SQLite database file */
+ public $mDatabaseFile;
+
+ /** @var int The number of rows affected as an integer */
+ protected $mAffectedRows;
+
+ /** @var resource */
+ protected $mLastResult;
/**
- * @var PDO
+ * @var string
+ * @todo Seems to serve no purpose. Remove?
*/
+ private $mName;
+
+ /** @var PDO */
protected $mConn;
function __construct( $p = null ) {
--
To view, visit https://gerrit.wikimedia.org/r/103874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9ef59cf070e379413d16a8d4456fd93df296442
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
