jenkins-bot has submitted this change and it was merged.
Change subject: No Reply button after clicking Be the first to comment
......................................................................
No Reply button after clicking Be the first to comment
Bug: 58005
Change-Id: Ia2b352e3f338295773135f3bf278f423479a4d13
---
M modules/discussion/ui.js
1 file changed, 9 insertions(+), 10 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/discussion/ui.js b/modules/discussion/ui.js
index 6aaef17..fcdf244 100644
--- a/modules/discussion/ui.js
+++ b/modules/discussion/ui.js
@@ -256,17 +256,16 @@
// Set up the scroll to new topic reply form
$container.find( '.flow-topic-comments .flow-reply-link'
).click(
function( e ) {
- var $hideElement = $( this ).closest(
'.flow-topic-container' ).children( '.flow-post-container' ), self = this;
+ var $showElement = $( this ).closest(
'.flow-topic-container' ).children( '.flow-post-container' ),
+ $replyContainer = $(
'#flow-topic-reply-' + $( this ).data( 'topic-id' ) );
+
e.stopPropagation();
-
- $hideElement.slideDown( function() {
- var $replyContainer = $(
'#flow-topic-reply-' + $( self ).data( 'topic-id' ) );
-
- $replyContainer.scrollIntoView( {
- 'complete': function () {
- $replyContainer.find(
'.flow-topic-reply-content' ).click();
- }
- } );
+ $replyContainer
+ .find( '.flow-topic-reply-content' )
+ .click()
+ .focus();
+ $showElement.slideDown( function() {
+ $replyContainer.scrollIntoView();
} );
}
);
--
To view, visit https://gerrit.wikimedia.org/r/101164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2b352e3f338295773135f3bf278f423479a4d13
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
