Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/104042
Change subject: Remove Exif::makeFormattedData and Exif::getFormattedData ...................................................................... Remove Exif::makeFormattedData and Exif::getFormattedData Both unused in core and Gerrit extensions. Deprecated since MediaWiki 1.18. Change-Id: I59e9bb5a368ffcbae1634395c0062fea0e754972 --- M RELEASE-NOTES-1.23 M includes/media/Exif.php 2 files changed, 2 insertions(+), 29 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/42/104042/1 diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23 index b933a31..fec16ab 100644 --- a/RELEASE-NOTES-1.23 +++ b/RELEASE-NOTES-1.23 @@ -101,6 +101,8 @@ - LoadMonitor_MySQL to LoadMonitorMySQL - LoadMonitor_Null to LoadMonitorNull * Removed methods: + - Exif:: (deprecated in 1.18) + - Exif:: () (deprecated in 1.18) - Linker::makeBrokenLink() (deprecated in 1.16) - Linker::makeBrokenLinkObj() (deprecated in 1.16) - Linker::makeColouredLinkObj() (deprecated in 1.16) diff --git a/includes/media/Exif.php b/includes/media/Exif.php index bb5e344..0fff361 100644 --- a/includes/media/Exif.php +++ b/includes/media/Exif.php @@ -553,18 +553,6 @@ } } - /** - * Use FormatMetadata to create formatted values for display to user - * (is this ever used?) - * - * @deprecated since 1.18 - */ - function makeFormattedData() { - wfDeprecated( __METHOD__, '1.18' ); - $this->mFormattedExifData = FormatMetadata::getFormattedData( - $this->mFilteredExifData ); - } - /**#@-*/ /**#@+ @@ -583,23 +571,6 @@ */ function getFilteredData() { return $this->mFilteredExifData; - } - - /** - * Get $this->mFormattedExifData - * - * This returns the data for display to user. - * Its unclear if this is ever used. - * - * @deprecated since 1.18 - */ - function getFormattedData() { - wfDeprecated( __METHOD__, '1.18' ); - if ( !$this->mFormattedExifData ) { - $this->makeFormattedData(); - } - - return $this->mFormattedExifData; } /**#@-*/ -- To view, visit https://gerrit.wikimedia.org/r/104042 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I59e9bb5a368ffcbae1634395c0062fea0e754972 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits