Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/104049


Change subject: Type cast formatted time
......................................................................

Type cast formatted time

Static code analyser warned for possible incorrect string concatenation
operator. Now it's clear what type we're dealing with.

Change-Id: Ic9f19479379ec2c6f4cb087ade44235fb110318c
---
M includes/parser/Parser.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/49/104049/1

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 9be75ae..dea9895 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -2941,7 +2941,7 @@
                                $value = ( wfUrlencode( 
$this->mTitle->getSubjectNsText() ) );
                                break;
                        case 'currentdayname':
-                               $value = $pageLang->getWeekdayName( 
MWTimestamp::getInstance( $ts )->format( 'w' ) + 1 );
+                               $value = $pageLang->getWeekdayName( 
(int)MWTimestamp::getInstance( $ts )->format( 'w' ) + 1 );
                                break;
                        case 'currentyear':
                                $value = $pageLang->formatNum( 
MWTimestamp::getInstance( $ts )->format( 'Y' ), true );
@@ -2961,7 +2961,7 @@
                                $value = $pageLang->formatNum( 
MWTimestamp::getInstance( $ts )->format( 'w' ) );
                                break;
                        case 'localdayname':
-                               $value = $pageLang->getWeekdayName( 
MWTimestamp::getLocalInstance( $ts )->format( 'w' ) + 1 );
+                               $value = $pageLang->getWeekdayName( 
(int)MWTimestamp::getLocalInstance( $ts )->format( 'w' ) + 1 );
                                break;
                        case 'localyear':
                                $value = $pageLang->formatNum( 
MWTimestamp::getLocalInstance( $ts )->format( 'Y' ), true );

-- 
To view, visit https://gerrit.wikimedia.org/r/104049
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9f19479379ec2c6f4cb087ade44235fb110318c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to