jenkins-bot has submitted this change and it was merged.
Change subject: Remove dupicate scrollTo event for topic reply link
......................................................................
Remove dupicate scrollTo event for topic reply link
The event is already defined in $container.find( '.flow-reply-link' ).click(
... )
Change-Id: I3594d1a121b549f447b1650c36de3c39233e7267
---
M modules/discussion/ui.js
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/discussion/ui.js b/modules/discussion/ui.js
index fcdf244..7a3735c 100644
--- a/modules/discussion/ui.js
+++ b/modules/discussion/ui.js
@@ -253,23 +253,6 @@
$( this ).flow( 'setupPreview' );
} );
- // Set up the scroll to new topic reply form
- $container.find( '.flow-topic-comments .flow-reply-link'
).click(
- function( e ) {
- var $showElement = $( this ).closest(
'.flow-topic-container' ).children( '.flow-post-container' ),
- $replyContainer = $(
'#flow-topic-reply-' + $( this ).data( 'topic-id' ) );
-
- e.stopPropagation();
- $replyContainer
- .find( '.flow-topic-reply-content' )
- .click()
- .focus();
- $showElement.slideDown( function() {
- $replyContainer.scrollIntoView();
- } );
- }
- );
-
// Set up folding
var $topicContainers = $container.is( '.flow-topic-container' )
? $container : $container.find( '.flow-topic-container' );
$topicContainers
--
To view, visit https://gerrit.wikimedia.org/r/103593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3594d1a121b549f447b1650c36de3c39233e7267
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
