Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/104149


Change subject: mw.loader.store: Detect malformed function stringification
......................................................................

mw.loader.store: Detect malformed function stringification

See the bug for details.

This seems to happen somewhat consistently on Opera 12, let's
try to work around the browser bug before we blacklist it.

Includes some console logging.

Bug: 57567
Change-Id: Ifd7b203fb0ca61e4a749e6b0fc031e62121cc45a
---
M resources/mediawiki/mediawiki.js
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/49/104149/1

diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index 89da4a2..f3bb414 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -1960,6 +1960,12 @@
                                                                JSON.stringify( 
descriptor.style ),
                                                                JSON.stringify( 
descriptor.messages )
                                                        ];
+                                                       // Attempted workaround 
for a possible Opera bug (bug 57567).
+                                                       // This regex should 
never match under sane conditions.
+                                                       if ( /^\s*\(/.test( 
args[1] ) ) {
+                                                               args[1] = 
'function' + args[1];
+                                                               log( 'Detected 
malformed function stringification (bug 57567)' );
+                                                       }
                                                } catch ( e ) {
                                                        return;
                                                }

-- 
To view, visit https://gerrit.wikimedia.org/r/104149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd7b203fb0ca61e4a749e6b0fc031e62121cc45a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to