Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/104174
Change subject: HYGIENE: Making sure people don't confuse the two notification
systems.
......................................................................
HYGIENE: Making sure people don't confuse the two notification systems.
Change-Id: I81b391d5ceb8532af11432fd5431aae85c9d7bd5
---
M javascripts/common/notification.js
M javascripts/modules/notifications/notifications.js
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/74/104174/1
diff --git a/javascripts/common/notification.js
b/javascripts/common/notification.js
index 7a4d200..105b6ab 100644
--- a/javascripts/common/notification.js
+++ b/javascripts/common/notification.js
@@ -1,3 +1,6 @@
+/**
+ * This code controls the Toast notifications, not to be confused with Echo
notifications.
+ */
( function( M ) {
var Drawer = M.require( 'Drawer' ), Toast;
diff --git a/javascripts/modules/notifications/notifications.js
b/javascripts/modules/notifications/notifications.js
index 199768b..37494b5 100644
--- a/javascripts/modules/notifications/notifications.js
+++ b/javascripts/modules/notifications/notifications.js
@@ -1,3 +1,7 @@
+/**
+ * This code loads the necessary modules for the notifications overlay, not to
be confused
+ * with the Toast notifications defined by common/notification.js.
+ */
( function( M, $ ) {
var useNewOverlays = M.isBetaGroupMember(),
LoadingOverlay = useNewOverlays ? M.require(
'LoadingOverlayNew' ) : M.require( 'LoadingOverlay' );
--
To view, visit https://gerrit.wikimedia.org/r/104174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81b391d5ceb8532af11432fd5431aae85c9d7bd5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
