jenkins-bot has submitted this change and it was merged.
Change subject: Declare visibility for class properties in DatabaseMssql
......................................................................
Declare visibility for class properties in DatabaseMssql
Change-Id: Icf0209a1f1f601a50dbc1e8cf59ca0b8afabd40f
---
M includes/db/DatabaseMssql.php
1 file changed, 14 insertions(+), 5 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php
index 5a5eab1..96b4c15 100644
--- a/includes/db/DatabaseMssql.php
+++ b/includes/db/DatabaseMssql.php
@@ -28,11 +28,20 @@
* @ingroup Database
*/
class DatabaseMssql extends DatabaseBase {
- var $mInsertId = null;
- var $mLastResult = null;
- var $mAffectedRows = null;
+ /** @var resource */
+ protected $mLastResult = null;
- var $mPort;
+ /** @var int The number of rows affected as an integer */
+ protected $mAffectedRows = null;
+
+ /**
+ * @var int Post number for database
+ * @todo Unused and can be removed?
+ */
+ protected $mPort;
+
+ /** @var int */
+ private $mInsertId = null;
function cascadingDeletes() {
return true;
@@ -271,7 +280,7 @@
/**
* This must be called after nextSequenceVal
- * @return null
+ * @return int|null
*/
function insertId() {
return $this->mInsertId;
--
To view, visit https://gerrit.wikimedia.org/r/103879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf0209a1f1f601a50dbc1e8cf59ca0b8afabd40f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
