Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/104712


Change subject: Specify version for git-review package resource
......................................................................

Specify version for git-review package resource

ensure => latest doesn't work well with the pip provider. legoktm was getting
the following output:

  /Stage[main]/Git/Package[git-review]: Could not evaluate: Could not get
  latest version: Wrong size. Was 0, should be <unknown>

This tracks my experience with the pip provider in the past. The fix is the
same as the fix for phpsh: hard-code a specific version number. Blech.

Change-Id: Ia9bce22ae5cf460a5f4984164d7e029cc9b52cdd
---
M puppet/modules/git/manifests/init.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/12/104712/1

diff --git a/puppet/modules/git/manifests/init.pp 
b/puppet/modules/git/manifests/init.pp
index 7ffbfe7..854845a 100644
--- a/puppet/modules/git/manifests/init.pp
+++ b/puppet/modules/git/manifests/init.pp
@@ -27,7 +27,7 @@
     }
 
     package { 'git-review':
-        ensure   => latest,
+        ensure   => '1.23',
         provider => pip,
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/104712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9bce22ae5cf460a5f4984164d7e029cc9b52cdd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to