Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/104719
Change subject: Fix the Autonym tests after the removal of the 'end' class ...................................................................... Fix the Autonym tests after the removal of the 'end' class The end class was removed at https://github.com/wikimedia/jquery.uls/pull/122 Change-Id: I548df1f14025cac0c4a89401474171d0558ff8b1 --- M tests/browser/features/step_definitions/panel_steps.rb M tests/browser/features/support/pages/panel_page.rb 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/19/104719/1 diff --git a/tests/browser/features/step_definitions/panel_steps.rb b/tests/browser/features/step_definitions/panel_steps.rb index b34882c..c5835c2 100644 --- a/tests/browser/features/step_definitions/panel_steps.rb +++ b/tests/browser/features/step_definitions/panel_steps.rb @@ -73,7 +73,7 @@ end Then(/^the language list of ULS should use Autonym font$/) do - on(PanelPage).autonym_element.style("font-family").should == "'Autonym',sans-serif" + on(PanelPage).uls_language_name_item("en").style("font-family").should == "'Autonym',sans-serif" end Then(/^I should see (.*) as the selected input language$/) do |language| diff --git a/tests/browser/features/support/pages/panel_page.rb b/tests/browser/features/support/pages/panel_page.rb index bd0a303..9374845 100644 --- a/tests/browser/features/support/pages/panel_page.rb +++ b/tests/browser/features/support/pages/panel_page.rb @@ -17,8 +17,6 @@ div(:panel_side_display, id: "display-panel-trigger") div(:panel_side_input, id: "input-panel-trigger") - ul(:autonym, class: "three columns end") - span(:panel_button_close, id: "languagesettings-close") button(:panel_button_apply, class: "uls-settings-apply") button(:panel_button_cancel, class: "uls-settings-cancel") @@ -48,6 +46,10 @@ # Is there way to access the html element? div(:interface, id: "footer") + def uls_language_name_item(language) + @browser.element(css: ".uls-language-block li[lang=#{language}] a") + end + def content_font font("#mw-content-text") end -- To view, visit https://gerrit.wikimedia.org/r/104719 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I548df1f14025cac0c4a89401474171d0558ff8b1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
