Cmcmahon has submitted this change and it was merged. Change subject: Clean up meaningless "post body" language ......................................................................
Clean up meaningless "post body" language A post is the chunk of wiki text, it doesn't have a separate body (see https://www.mediawiki.org/wiki/Flow_Portal/Nomenclature ). So this rephrases some test language. Also fix a mistaken "saved topic body" reference. There's still mention of "topic body" and "create a Body of Flow Topic into Flow body". When you create a topic you're invited to add a first post to it at the same time. FWIW I think the only reasonable meaning of "topic body" is the tree of posts under a topic that is hidden when you click a topic bar Change-Id: I7bcf5bccf98477534ad53dd0f084fb1539db9710 --- M tests/browser/features/edit_existing.feature M tests/browser/features/step_definitions/edit_existing_steps.rb 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Cmcmahon: Looks good to me, approved diff --git a/tests/browser/features/edit_existing.feature b/tests/browser/features/edit_existing.feature index f0a321b..e43819e 100644 --- a/tests/browser/features/edit_existing.feature +++ b/tests/browser/features/edit_existing.feature @@ -18,5 +18,5 @@ Given I am on Flow page When I click the Edit post pencil icon Then I should be able to edit the post field with Post edited - And I should be able to save the new post body - And the saved topic body should contain Post edited + And I should be able to save the new post + And the saved post should contain Post edited diff --git a/tests/browser/features/step_definitions/edit_existing_steps.rb b/tests/browser/features/step_definitions/edit_existing_steps.rb index 98a5603..21f5de7 100644 --- a/tests/browser/features/step_definitions/edit_existing_steps.rb +++ b/tests/browser/features/step_definitions/edit_existing_steps.rb @@ -20,7 +20,7 @@ on(FlowPage).title_edit_element.when_present.send_keys(edited_title + @random_string) end -Then(/^I should be able to save the new post body$/) do +Then(/^I should be able to save the new post/) do on(FlowPage).change_post_save_element.when_present.click end @@ -28,7 +28,7 @@ on(FlowPage).change_title_save_element.when_present.click end -Then(/^the saved topic body should contain (.+)$/) do |edited_post| +Then(/^the saved post should contain (.+)$/) do |edited_post| on(FlowPage) do |page| page.small_spinner_element.when_not_present page.topic_post.should match(edited_post + @random_string) -- To view, visit https://gerrit.wikimedia.org/r/102594 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bcf5bccf98477534ad53dd0f084fb1539db9710 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
