jenkins-bot has submitted this change and it was merged.
Change subject: Avoid errors like "TypeError: response.error is undefined"
......................................................................
Avoid errors like "TypeError: response.error is undefined"
We *might* want to log these failures as they can be severe.
Change-Id: Ib53cd76c086c34244b4e9ced3072f3f036a92141
---
M resources/js/ext.translate.editor.js
M resources/js/ext.translate.special.translationstash.js
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index 1252974..cd92fa0 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -195,7 +195,7 @@
translateEditor.message.translation =
translation;
translateEditor.onSaveSuccess();
} ).fail( function ( errorCode, response ) {
- translateEditor.onSaveFail( response.error.info
);
+ translateEditor.onSaveFail( response.error &&
response.error.info || 'Unknown error' );
} );
},
diff --git a/resources/js/ext.translate.special.translationstash.js
b/resources/js/ext.translate.special.translationstash.js
index 9bf8e2b..b0ca96e 100644
--- a/resources/js/ext.translate.special.translationstash.js
+++ b/resources/js/ext.translate.special.translationstash.js
@@ -194,7 +194,9 @@
updateStats();
} ).fail( function ( errorCode, response ) {
$messageTable.empty().addClass( 'error' )
- .text( 'Error: ' + errorCode + ' - ' +
response.error.info );
+ .text( 'Error: ' + errorCode + ' - ' +
+ ( response.error &&
response.error.info || 'Unknown error' )
+ );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/103244
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib53cd76c086c34244b4e9ced3072f3f036a92141
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
