Ori.livneh has submitted this change and it was merged.

Change subject: Make logscale in reqerror graphs actually work
......................................................................


Make logscale in reqerror graphs actually work

Also tweak graph titles.
This fix depends on a graphite update which AFAIK already happened.
10 as log base: the yearly graph has values across 4 orders of magnitudes.

Bug: 41754
Change-Id: Iae1c2b97f3f81e60c27a8af5cbd33f772576bbe3
---
M files/graphite/gdash/dashboards/reqerror/10.4xx-1y.graph
M files/graphite/gdash/dashboards/reqerror/7.5xx-2m.graph
M files/graphite/gdash/dashboards/reqerror/8.4xx-2m.graph
M files/graphite/gdash/dashboards/reqerror/9.5xx-1y.graph
4 files changed, 10 insertions(+), 12 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/files/graphite/gdash/dashboards/reqerror/10.4xx-1y.graph 
b/files/graphite/gdash/dashboards/reqerror/10.4xx-1y.graph
index a948e1d..804c310 100644
--- a/files/graphite/gdash/dashboards/reqerror/10.4xx-1y.graph
+++ b/files/graphite/gdash/dashboards/reqerror/10.4xx-1y.graph
@@ -1,4 +1,4 @@
-title   "HTTP 4xx Responses/hour -1week"
+title   "HTTP 4xx Responses/hour -1year"
 linewidth 2
 linemode "connected"
 hide_legend "false"
diff --git a/files/graphite/gdash/dashboards/reqerror/7.5xx-2m.graph 
b/files/graphite/gdash/dashboards/reqerror/7.5xx-2m.graph
index d70206c..90af6ad 100644
--- a/files/graphite/gdash/dashboards/reqerror/7.5xx-2m.graph
+++ b/files/graphite/gdash/dashboards/reqerror/7.5xx-2m.graph
@@ -1,16 +1,15 @@
-title   "HTTP 5xx Responses/hour -1week"
+title   "HTTP 5xx Responses/hour -2month"
 linewidth 2
+logbase 10
 linemode "connected"
 hide_legend "false"
 from "-2month"
 
 field :a, :color => "red",
                :alias => "none",
-               :data  => 'cactiStyle(alias(summarize(reqstats.500,"1h"),"500 
resp/hour"))',
-               :logbase => 10
+               :data  => 'cactiStyle(alias(summarize(reqstats.500,"1h"),"500 
resp/hour"))'
 
 field :b, :color => "blue",
                :alias => "none",
-               :data  => 'cactiStyle(alias(summarize(reqstats.5xx,"1h"),"5xx 
resp/hour"))',
-               :logbase => 10
+               :data  => 'cactiStyle(alias(summarize(reqstats.5xx,"1h"),"5xx 
resp/hour"))'
 
diff --git a/files/graphite/gdash/dashboards/reqerror/8.4xx-2m.graph 
b/files/graphite/gdash/dashboards/reqerror/8.4xx-2m.graph
index c810a02..cf70ee3 100644
--- a/files/graphite/gdash/dashboards/reqerror/8.4xx-2m.graph
+++ b/files/graphite/gdash/dashboards/reqerror/8.4xx-2m.graph
@@ -1,4 +1,4 @@
-title   "HTTP 4xx Responses/hour -1week"
+title   "HTTP 4xx Responses/hour -2month"
 linewidth 2
 linemode "connected"
 hide_legend "false"
diff --git a/files/graphite/gdash/dashboards/reqerror/9.5xx-1y.graph 
b/files/graphite/gdash/dashboards/reqerror/9.5xx-1y.graph
index 81b0db5..d1c6a5d 100644
--- a/files/graphite/gdash/dashboards/reqerror/9.5xx-1y.graph
+++ b/files/graphite/gdash/dashboards/reqerror/9.5xx-1y.graph
@@ -1,16 +1,15 @@
-title   "HTTP 5xx Responses/hour -1week"
+title   "HTTP 5xx Responses/hour -1year"
 linewidth 2
+logbase 10
 linemode "connected"
 hide_legend "false"
 from "-1year"
 
 field :a, :color => "red",
                :alias => "none",
-               :data  => 'cactiStyle(alias(summarize(reqstats.500,"1h"),"500 
resp/hour"))',
-               :logbase => 10
+               :data  => 'cactiStyle(alias(summarize(reqstats.500,"1h"),"500 
resp/hour"))'
 
 field :b, :color => "blue",
                :alias => "none",
-               :data  => 'cactiStyle(alias(summarize(reqstats.5xx,"1h"),"5xx 
resp/hour"))',
-               :logbase => 10
+               :data  => 'cactiStyle(alias(summarize(reqstats.5xx,"1h"),"5xx 
resp/hour"))'
 

-- 
To view, visit https://gerrit.wikimedia.org/r/101065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1c2b97f3f81e60c27a8af5cbd33f772576bbe3
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to