jenkins-bot has submitted this change and it was merged.
Change subject: No need to return true/false from AutoLoader
......................................................................
No need to return true/false from AutoLoader
Partially reverts r36942 (7e627faec6bd).
Change-Id: I5b3dfd148863413025c71de5fadef1cb5bd70dce
---
M includes/AutoLoader.php
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Parent5446: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/AutoLoader.php b/includes/AutoLoader.php
index a9b0376..cd062e0 100644
--- a/includes/AutoLoader.php
+++ b/includes/AutoLoader.php
@@ -1157,9 +1157,6 @@
* autoload - take a class name and attempt to load it
*
* @param string $className name of class we're looking for.
- * @return bool Returning false is important on failure as
- * it allows Zend to try and look in other registered autoloaders
- * as well.
*/
static function autoload( $className ) {
global $wgAutoloadClasses, $wgAutoloadLocalClasses,
@@ -1209,7 +1206,7 @@
}
# Give up
- return false;
+ return;
}
# Make an absolute path, this improves performance by avoiding
some stat calls
@@ -1219,8 +1216,6 @@
}
require $filename;
-
- return true;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/105635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b3dfd148863413025c71de5fadef1cb5bd70dce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
