Nullzero has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/105637


Change subject: always show diff link if available
......................................................................

always show diff link if available

This patch makes a diff link appear in Special:Abuselog no matter a filter
is public or private. Because there is much information to figure out which
revision a filter catches, showing a diff link will make patrollers more
convenient without leaking more information. Note that when a filter
prevents an action, there will be no diff link. Since parser functions
are not available, a way to display correctly is to concatenate $diffLink
to $parsed_comments directly.

Bug: 59695
Change-Id: I6a4432cbb41ae78583cc87355514f252984c1005
---
M special/SpecialAbuseLog.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/37/105637/1

diff --git a/special/SpecialAbuseLog.php b/special/SpecialAbuseLog.php
index 96437c7..b3d89fa 100644
--- a/special/SpecialAbuseLog.php
+++ b/special/SpecialAbuseLog.php
@@ -530,6 +530,10 @@
                                $row->afl_user_text
                        )->parse();
                } else {
+                       if ($diffLink)
+                               // concatenate strings, not increase the 
parameter (in AbuseFilter.i18n), because sometimes the link might not exist
+                               $parsed_comments .= " ($diffLink)"; 
+                       
                        $description = $this->msg( 'abusefilter-log-entry' 
)->rawParams(
                                $timestamp,
                                $userLink,

-- 
To view, visit https://gerrit.wikimedia.org/r/105637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a4432cbb41ae78583cc87355514f252984c1005
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Nullzero <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to