jenkins-bot has submitted this change and it was merged.
Change subject: Force CSSJanus to not flip image alignment classes
......................................................................
Force CSSJanus to not flip image alignment classes
For some reason, the class-wide /*@noflip*/ on mw-halign-left and
mw-halign-right didn't 'catch' and cssjanus ended up flipping the
float directions in RTL. This fix forces noflip condition on each
of the lines separately, which seems to work.
Bug: 50910
Change-Id: I4cddce80397d821dc3cbf40ee4b4c471890d8d35
---
M modules/ve-mw/ce/styles/ve.ce.Node.css
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/styles/ve.ce.Node.css
b/modules/ve-mw/ce/styles/ve.ce.Node.css
index 442cb2b..6aeff41 100644
--- a/modules/ve-mw/ce/styles/ve.ce.Node.css
+++ b/modules/ve-mw/ce/styles/ve.ce.Node.css
@@ -57,10 +57,15 @@
}
/* TODO: Merge with div.tright styles */
-/* @noflip */
+/* Due to a weird cssjanus bug, noflip rules
+ are set as single-rules rather than for the
+ whole class */
figure[typeof*='mw:Image'].mw-halign-right {
+ /* @noflip */
clear: right;
+ /* @noflip */
float: right;
+ /* @noflip */
margin: .5em 0 1.3em 1.4em;
}
@@ -70,10 +75,15 @@
}
/* TODO: Merge with div.tleft styles */
-/* @noflip */
+/* Due to a weird cssjanus bug, noflip rules
+ are set as single-rules rather than for the
+ whole class */
figure[typeof*='mw:Image'].mw-halign-left {
+ /* @noflip */
clear: left;
+ /* @noflip */
float: left;
+ /* @noflip */
margin: .5em 1.4em 1.3em 0;
}
--
To view, visit https://gerrit.wikimedia.org/r/105640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cddce80397d821dc3cbf40ee4b4c471890d8d35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
