Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/106219
Change subject: Improved vague/incomplete $1 thumb.php error messages
......................................................................
Improved vague/incomplete $1 thumb.php error messages
Change-Id: I64d05e25f82242e92abbcbf20252fc17d5790d8b
---
M includes/media/Bitmap.php
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/19/106219/1
diff --git a/includes/media/Bitmap.php b/includes/media/Bitmap.php
index 1be04a7..8a5c3ae 100644
--- a/includes/media/Bitmap.php
+++ b/includes/media/Bitmap.php
@@ -187,7 +187,9 @@
wfHostname(), $image->getName() ) );
return new MediaTransformError( 'thumbnail_error',
- $scalerParams['clientWidth'],
$scalerParams['clientHeight'] );
+ $scalerParams['clientWidth'],
$scalerParams['clientHeight'],
+ 'Could not get retrieve copy of original'
+ );
}
# Try a hook
@@ -227,7 +229,9 @@
} elseif ( $removed ) {
# Thumbnail was zero-byte and had to be removed
return new MediaTransformError( 'thumbnail_error',
- $scalerParams['clientWidth'],
$scalerParams['clientHeight'] );
+ $scalerParams['clientWidth'],
$scalerParams['clientHeight'],
+ 'Thumbnail was 0 bytes when created'
+ );
} elseif ( $mto ) {
return $mto;
} else {
--
To view, visit https://gerrit.wikimedia.org/r/106219
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64d05e25f82242e92abbcbf20252fc17d5790d8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
