jenkins-bot has submitted this change and it was merged.
Change subject: Protect against JS error when langlinks API query returns an
error
......................................................................
Protect against JS error when langlinks API query returns an error
This happens e.g. when opening VE on a redirect page.
Change-Id: I75b77da42013c3d446cbc9c57aebe0907a2b40dc
---
M modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
index 1462b10..9474750 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
@@ -95,7 +95,8 @@
* Handle language items being loaded.
*/
ve.ui.MWLanguagesPage.prototype.onAllLanguageItemsSuccess = function (
deferred, response ) {
- var i, iLen, languages = [], langlinks =
response.visualeditor.langlinks;
+ var i, iLen, languages = [],
+ langlinks = response && response.visualeditor &&
response.visualeditor.langlinks;
if ( langlinks ) {
for ( i = 0, iLen = langlinks.length; i < iLen; i++ ) {
languages.push( {
--
To view, visit https://gerrit.wikimedia.org/r/105887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75b77da42013c3d446cbc9c57aebe0907a2b40dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
