MaxSem has submitted this change and it was merged.
Change subject: Fixed broken concatenation causing diff breakage in mobile
......................................................................
Fixed broken concatenation causing diff breakage in mobile
The reason this bug came into existence is very bizarre. When code
reviewing Change-Id: Id7adcf34601b918a2c0a601a1a1690e602a5989b, I
noticed that only the final line of diff was being shown (patchset 19).
I pointed it out to MaxSem, and he fixed it (patchset 20). I updated the
commit message via Gerrit (resulting in patchset 21), and +2'd the
change. I didn't realize it at the time, but patchset 21 for some reason
did not contain Max's fix in patchset 20, thus introducing the bug to
production.
Bug: 59848
Change-Id: I56589b194a99e68f8809921eabf86224bd2fa57a
(cherry picked from commit 66dc7510e0f7579dc35b3165ebe34ee770cbac5f)
---
M includes/specials/SpecialMobileDiff.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
MaxSem: Verified; Looks good to me, approved
diff --git a/includes/specials/SpecialMobileDiff.php
b/includes/specials/SpecialMobileDiff.php
index 4643569..848e1eb 100644
--- a/includes/specials/SpecialMobileDiff.php
+++ b/includes/specials/SpecialMobileDiff.php
@@ -205,7 +205,7 @@
} else {
$tag = Html::element( 'ins', array(),
$el->nodeValue );
}
- $out = "<div>$tag</div>";
+ $out .= "<div>$tag</div>";
}
return $out;
--
To view, visit https://gerrit.wikimedia.org/r/106641
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56589b194a99e68f8809921eabf86224bd2fa57a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.23wmf10
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
