jenkins-bot has submitted this change and it was merged.
Change subject: Cleanup of test steps
......................................................................
Cleanup of test steps
According to Ċ½eljko's suggestions
Change-Id: I31569adf9af02ffc5ec71d04e69b74e0f1843416
---
M tests/browser/features/special_content_translation.feature
M tests/browser/features/support/pages/content_translation_page.rb
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
KartikMistry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/special_content_translation.feature
b/tests/browser/features/special_content_translation.feature
index f64b57b..31a473b 100644
--- a/tests/browser/features/special_content_translation.feature
+++ b/tests/browser/features/special_content_translation.feature
@@ -11,7 +11,7 @@
These scenarios test the basic functionality of the
Special:ContentTranslation page.
Scenario: Anonymous user cannot use Content translation.
- Given I am on the content translation page in a wiki in English,
translating the page "Bratislava" to Danish
+ When I am on the content translation page in a wiki in English,
translating the page "Bratislava" to Danish
Then I see the message "You must be logged in to translate in this page."
And I don't see the source column
And I don't see the translation column
@@ -19,7 +19,7 @@
Scenario: Logged in user viewing the special page for translation.
Given I am logged in
- And I am on the content translation page in a wiki in English,
translating the page "Bratislava" to Danish
+ When I am on the content translation page in a wiki in English,
translating the page "Bratislava" to Danish
Then I see a source column with the content of the page "Bratislava"
And the language code of the source column is "en"
And the direction of the source column is "ltr"
diff --git a/tests/browser/features/support/pages/content_translation_page.rb
b/tests/browser/features/support/pages/content_translation_page.rb
index 9864d34..0a5224d 100644
--- a/tests/browser/features/support/pages/content_translation_page.rb
+++ b/tests/browser/features/support/pages/content_translation_page.rb
@@ -26,6 +26,6 @@
end
def translation_editor
- @browser.div(class: "translation-editor")
+ column("translation").div(class: "translation-editor")
end
end
--
To view, visit https://gerrit.wikimedia.org/r/106691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31569adf9af02ffc5ec71d04e69b74e0f1843416
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
