MarkTraceur has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106849


Change subject: Add main class to jsduck
......................................................................

Add main class to jsduck

Change-Id: I774303ce4f756637bea3821ae2b2ff724351b3bb
---
M docs/external.js
M docs/jsduck-config.json
M resources/ext.multimediaViewer/ext.multimediaViewer.js
M resources/ext.multimediaViewer/ext.multimediaViewer.lightboximage.js
4 files changed, 44 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/49/106849/1

diff --git a/docs/external.js b/docs/external.js
index e670c92..0cd19ce 100644
--- a/docs/external.js
+++ b/docs/external.js
@@ -5,6 +5,11 @@
  */
 
 /**
+ * @class mw.Api
+ * <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Api>
+ */
+
+/**
  * @class mw.Title
  * <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Title>
  */
@@ -15,5 +20,34 @@
  */
 
 /**
+ * @class mlb.LightboxImage
+ */
+
+/**
  * @class mlb.LightboxInterface
  */
+
+/**
+ * @class mlb.MultiLightbox
+ */
+
+/**
+ * @class HTMLElement
+ */
+
+/**
+ * @class HTMLImageElement
+ * @extends HTMLElement
+ */
+
+/**
+ * @class jQuery
+ */
+
+/**
+ * @class jQuery.Promise
+ */
+
+/**
+ * @class jQuery.Event
+ */
diff --git a/docs/jsduck-config.json b/docs/jsduck-config.json
index 25431a7..98f1d4e 100644
--- a/docs/jsduck-config.json
+++ b/docs/jsduck-config.json
@@ -6,6 +6,7 @@
        "--output": "./js",
        "--": [
                "./external.js",
+               "../resources/ext.multimediaViewer/ext.multimediaViewer.js",
                
"../resources/ext.multimediaViewer/ext.multimediaViewer.lightboxinterface.js",
                
"../resources/ext.multimediaViewer/ext.multimediaViewer.lightboximage.js"
        ]
diff --git a/resources/ext.multimediaViewer/ext.multimediaViewer.js 
b/resources/ext.multimediaViewer/ext.multimediaViewer.js
index 09ff6d1..edbdbca 100755
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.js
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.js
@@ -68,15 +68,15 @@
                };
 
        /**
-        * Class that analyses the page, looks for image content and sets up 
the hooks
+        * @class mw.MultimediaViewer
+        * Analyses the page, looks for image content and sets up the hooks
         * to manage the viewing experience of such content.
-        *
         * @constructor
         */
        function MultimediaViewer() {
                /**
                 * MultiLightbox object used to display the pictures in the 
page.
-                * @property {mw.MultiLightbox}
+                * @property {mlb.MultiLightbox}
                 * @private
                 */
                this.lightbox = null;
@@ -277,7 +277,6 @@
         * Handles clicks on legit image links.
         *
         * @protected
-        * @VisibleForTesting
         *
         * @param {jQuery.Event} e click event
         * @param {HTMLElement|jQuery} clickedEle clicked element
@@ -327,7 +326,7 @@
         *
         * @protected
         *
-        * @param {LightboxInterface} ui lightbox that got resized
+        * @param {mw.LightboxInterface} ui lightbox that got resized
         * @param {Object} imageInfo information regarding the new resized image
         * @param {number} targetWidth
         */
@@ -854,7 +853,7 @@
                /**
                 * Start profiling an event
                 * @param {string} type Can be image-load, image-resize, 
metadata-fetch, gender-fetch
-                * @param {object} [imgSize] Size of image (for image related 
events)
+                * @param {Object} [imgSize] Size of image (for image related 
events)
                 * @param {number} [imgSize.width] In pixels
                 * @param {number} [imgSize.height] In pixels
                 * @param {number} [imgSize.filesize] In bytes
diff --git 
a/resources/ext.multimediaViewer/ext.multimediaViewer.lightboximage.js 
b/resources/ext.multimediaViewer/ext.multimediaViewer.lightboximage.js
index 69ec9fb..6e15350 100644
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.lightboximage.js
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.lightboximage.js
@@ -16,6 +16,10 @@
  */
 
 ( function ( mw, $, oo, MLBImage ) {
+       /**
+        * @class mw.LightboxImage
+        * @extends mlb.LightboxImage
+        */
        function LightboxImage() {
                MLBImage.call( this );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/106849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I774303ce4f756637bea3821ae2b2ff724351b3bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to