Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/107353
Change subject: Prevent race condition causing marshaller to not be registered
......................................................................
Prevent race condition causing marshaller to not be registered
Only happens sometimes and only on super fast phones.
Change-Id: Id73c3f2b2e65fdfc234d6492fc240ff55d210117
---
M wikipedia/src/main/java/org/wikipedia/CommunicationBridge.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/53/107353/1
diff --git a/wikipedia/src/main/java/org/wikipedia/CommunicationBridge.java
b/wikipedia/src/main/java/org/wikipedia/CommunicationBridge.java
index 103964d..4c1ddf5 100644
--- a/wikipedia/src/main/java/org/wikipedia/CommunicationBridge.java
+++ b/wikipedia/src/main/java/org/wikipedia/CommunicationBridge.java
@@ -31,10 +31,12 @@
this.marshaller = new BridgeMarshaller();
webView.getSettings().setJavaScriptEnabled(true);
- webView.loadUrl(baseURL);
webView.setWebChromeClient(new CommunicatingChrome());
webView.addJavascriptInterface(marshaller, "marshaller");
+
+ webView.loadUrl(baseURL);
+
eventListeners = new HashMap<String, ArrayList<JSEventListener>>();
this.addListener("DOMLoaded", new JSEventListener() {
@Override
--
To view, visit https://gerrit.wikimedia.org/r/107353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id73c3f2b2e65fdfc234d6492fc240ff55d210117
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
