Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/107365


Change subject: Varnish: brown paper bag fix for return(restart)
......................................................................

Varnish: brown paper bag fix for return(restart)

Apparently the author forgot his understanding of Varnish flow control
structures and basic arithmetics.

Change-Id: Iae0f99193f3857a1acdc9733a2124d50f7354c64
---
M modules/varnish/templates/vcl/wikimedia.vcl.erb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/65/107365/1

diff --git a/modules/varnish/templates/vcl/wikimedia.vcl.erb 
b/modules/varnish/templates/vcl/wikimedia.vcl.erb
index 1da3391..c509f2a 100644
--- a/modules/varnish/templates/vcl/wikimedia.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia.vcl.erb
@@ -310,10 +310,10 @@
                #
                # Note that max_restarts is 4 by default, so Varnish would
                # otherwise detect this as a loop and present its own 503.
-               if (req.restarts < 4) {
+               if (req.restarts < 3) {
                        return(restart);
                } else {
-                       return(pass);
+                       return(deliver);
                }
        }
 <% end -%>

-- 
To view, visit https://gerrit.wikimedia.org/r/107365
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae0f99193f3857a1acdc9733a2124d50f7354c64
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to