Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/107565
Change subject: Fix browser tests that were still using CamelCase names
......................................................................
Fix browser tests that were still using CamelCase names
Change-Id: I599c1363910a355e78df8434e93fec745b6df539
---
M tests/browser/features/step_definitions/delete_item_steps.rb
M tests/browser/features/step_definitions/edit_tab_steps.rb
M tests/browser/features/step_definitions/non_existing_item_steps.rb
D tests/browser/features/support/pages/noexisting_item_page.rb
A tests/browser/features/support/pages/non_existing_item_page.rb
5 files changed, 21 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/65/107565/1
diff --git a/tests/browser/features/step_definitions/delete_item_steps.rb
b/tests/browser/features/step_definitions/delete_item_steps.rb
index 7ff58e2..910716e 100644
--- a/tests/browser/features/step_definitions/delete_item_steps.rb
+++ b/tests/browser/features/step_definitions/delete_item_steps.rb
@@ -12,7 +12,7 @@
Then(/^Page should be deleted$/) do
on(ItemPage) do |page|
page.navigate_to_entity @item_under_test["url"]
- page.entityLabelSpan?.should be_false
- page.entityDescriptionSpan?.should be_false
+ page.entity_label_span?.should be_false
+ page.entity_description_span?.should be_false
end
end
diff --git a/tests/browser/features/step_definitions/edit_tab_steps.rb
b/tests/browser/features/step_definitions/edit_tab_steps.rb
index 0d84732..a6cde8e 100644
--- a/tests/browser/features/step_definitions/edit_tab_steps.rb
+++ b/tests/browser/features/step_definitions/edit_tab_steps.rb
@@ -6,5 +6,5 @@
# steps to check the edit tab functionality
Then(/^the edit\-tab button should not be visible$/) do
- on(ItemPage).editTab?.should be_false
+ on(ItemPage).edit_tab?.should be_false
end
diff --git a/tests/browser/features/step_definitions/non_existing_item_steps.rb
b/tests/browser/features/step_definitions/non_existing_item_steps.rb
index 7e6be1a..ebc8c6e 100644
--- a/tests/browser/features/step_definitions/non_existing_item_steps.rb
+++ b/tests/browser/features/step_definitions/non_existing_item_steps.rb
@@ -11,8 +11,7 @@
Then(/^check if this page behaves correctly$/) do
on_page(NonExistingItemPage) do |page|
- page.firstHeading.should be_true
- page.firstHeading_element.text.should == ITEM_NAMESPACE + ITEM_ID_PREFIX +
"xy"
+ page.first_heading.should be_true
+ page.first_heading_element.text.should == ITEM_NAMESPACE + ITEM_ID_PREFIX
+ "xy"
end
end
-
diff --git a/tests/browser/features/support/pages/noexisting_item_page.rb
b/tests/browser/features/support/pages/noexisting_item_page.rb
deleted file mode 100644
index 556d44d..0000000
--- a/tests/browser/features/support/pages/noexisting_item_page.rb
+++ /dev/null
@@ -1,16 +0,0 @@
-# -*- encoding : utf-8 -*-
-# Wikidata UI tests
-#
-# Author:: Tobias Gritschacher (tobias.gritschac...@wikimedia.de)
-# License:: GNU GPL v2+
-#
-# page object for a non existing item
-
-class NonExistingItemPage
- include PageObject
- page_url WIKIDATA_REPO_URL + ITEM_NAMESPACE + ITEM_ID_PREFIX + "xy"
-
- span(:firstHeading, :xpath => "//h1[@id='firstHeading']/span")
- link(:specialLogLink, :css => "div#mw-content-text > div > p > span >
a:nth-child(1)")
- link(:specialCreateNewItemLink, :css => "div#mw-content-text > div > p >
a:nth-child(2)")
-end
diff --git a/tests/browser/features/support/pages/non_existing_item_page.rb
b/tests/browser/features/support/pages/non_existing_item_page.rb
new file mode 100644
index 0000000..6caae7a
--- /dev/null
+++ b/tests/browser/features/support/pages/non_existing_item_page.rb
@@ -0,0 +1,16 @@
+# -*- encoding : utf-8 -*-
+# Wikidata UI tests
+#
+# Author:: Tobias Gritschacher (tobias.gritschac...@wikimedia.de)
+# License:: GNU GPL v2+
+#
+# page object for a non existing item
+
+class NonExistingItemPage
+ include PageObject
+ page_url WIKIDATA_REPO_URL + ITEM_NAMESPACE + ITEM_ID_PREFIX + "xy"
+
+ span(:first_heading, :xpath => "//h1[@id='firstHeading']/span")
+ link(:special_log_link, :css => "div#mw-content-text > div > p > span >
a:nth-child(1)")
+ link(:special_create_new_item_link, :css => "div#mw-content-text > div > p >
a:nth-child(2)")
+end
--
To view, visit https://gerrit.wikimedia.org/r/107565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I599c1363910a355e78df8434e93fec745b6df539
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
