Hashar has submitted this change and it was merged. Change subject: test: full coverage of Html::dropDefaults() ......................................................................
test: full coverage of Html::dropDefaults() This closely match Html::dropDefaults() logic and hopefully test out all default dropping. Introduce a test case that match a failure in f34547ab where attribute default values passed in an array are not cleaned up. Change-Id: If8d16b066015ed1bcaf38408511ac3713eaa6540 --- M includes/Html.php M tests/phpunit/includes/HtmlTest.php 2 files changed, 118 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/22005 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8d16b066015ed1bcaf38408511ac3713eaa6540 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Jens Ohlig <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
