Gerrit Patch Uploader has uploaded a new change for review.
https://gerrit.wikimedia.org/r/107837
Change subject: Patch to remove success box on changing any preference or
switching tab
......................................................................
Patch to remove success box on changing any preference or switching tab
Change-Id: Ia98081cfa393a2f7f4f512bbd46fcbdb6dd210b0
---
M resources/mediawiki.special/mediawiki.special.preferences.js
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/37/107837/1
diff --git a/resources/mediawiki.special/mediawiki.special.preferences.js
b/resources/mediawiki.special/mediawiki.special.preferences.js
index 3302ec6..794be54 100644
--- a/resources/mediawiki.special/mediawiki.special.preferences.js
+++ b/resources/mediawiki.special/mediawiki.special.preferences.js
@@ -76,6 +76,12 @@
$preferences.children( 'fieldset' ).hide().attr(
'aria-hidden', 'true' );
$( document.getElementById( 'mw-prefsection-' + name )
).show().attr( 'aria-hidden', 'false' );
+
+ //Remove successbox when any setting is changed
+ $( document.getElementById( 'mw-prefsection-' + name )
).change(
+ function() {
+ $('.successbox').remove();
+ });
}
}
@@ -85,6 +91,11 @@
ident, $li, $a;
if ( i === 0 ) {
$legend.parent().show();
+ //Remove success box when any setting is changed
+ $legend.parent().change(
+ function() {
+ $('.successbox').remove();
+ });
}
ident = $legend.parent().attr( 'id' );
@@ -120,6 +131,8 @@
}
if ( $el.length > 0 ) {
switchPrefTab( $el.attr( 'href' ).replace(
'#mw-prefsection-', '' ) );
+ //Remove successbox when tab is changed
+ $('.successbox').remove();
}
} );
@@ -140,6 +153,8 @@
( document.documentMode === undefined || document.documentMode
>= 8 )
) {
$(window).on( 'hashchange' , function () {
+ //Remove successbox when tab is changed
+ $('.successbox').remove();
var hash = window.location.hash;
if ( hash.match( /^#mw-prefsection-[\w\-]+/ ) ) {
switchPrefTab( hash.replace(
'#mw-prefsection-', '' ) );
--
To view, visit https://gerrit.wikimedia.org/r/107837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia98081cfa393a2f7f4f512bbd46fcbdb6dd210b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Kunalgrover05 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
