Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/107867
Change subject: Fix undefined variable
......................................................................
Fix undefined variable
Change-Id: Ie51ad6eaa78c19497f0c18e061064dfa52cb2025
---
M includes/ElasticsearchIntermediary.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/67/107867/1
diff --git a/includes/ElasticsearchIntermediary.php
b/includes/ElasticsearchIntermediary.php
index 32943a5..54b36c3 100644
--- a/includes/ElasticsearchIntermediary.php
+++ b/includes/ElasticsearchIntermediary.php
@@ -90,7 +90,7 @@
* @return \Status representing a backend failure
*/
public function failure( $exception ) {
- $this->finishRequest();
+ $took = $this->finishRequest();
wfLogWarning( "Search backend error during $this->description
after $took. " .
'Error message is: ' . $e->getMessage() );
return Status::newFatal( 'cirrussearch-backend-error' );
@@ -98,6 +98,7 @@
/**
* Log the completion of a request to Elasticsearch.
+ * @return int number of milliseconds it took to complete the request
*/
private function finishRequest() {
if ( !$this->requestStart ) {
@@ -129,5 +130,6 @@
wfDebugLog( 'CirrusSearchSlowRequests', $logMessage );
}
$this->requestStart = null;
+ return $took;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/107867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie51ad6eaa78c19497f0c18e061064dfa52cb2025
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
