jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Tools: Add SVGO, an SVG optimizer to pre-commit hook"
......................................................................
Revert "Tools: Add SVGO, an SVG optimizer to pre-commit hook"
Resulting SVGs are misdetected ad served as application/xml, see
Ie4db624ba9f561a467622878d0992847be018b7d
This reverts commit 3e944d795e2f4b7809791e6560cc3acfa0d234cb.
Change-Id: Ieeb5c97652b001e31f41cf2593a47a1bb4accc7f
---
M package.json
M scripts/pre-commit
2 files changed, 2 insertions(+), 15 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/package.json b/package.json
index 9a4c218..aa4f7b4 100644
--- a/package.json
+++ b/package.json
@@ -5,7 +5,6 @@
"dependencies": {
"jshint": ">=1.1.0",
"jsdoc": "<=3.3.0",
- "kss": ">=0.3.6",
- "svgo": ">=0.4.4"
+ "kss": ">=0.3.6"
}
}
diff --git a/scripts/pre-commit b/scripts/pre-commit
index b46cc1b..1ab1c40 100755
--- a/scripts/pre-commit
+++ b/scripts/pre-commit
@@ -26,18 +26,6 @@
optipng -q -o7 "$file" && advpng -z -4 "$file" && advdef -z -4
"$file" | grep "Output"
git add "$file"
else
- echo 'file was removed'
- fi
-done
-
-for file in `git diff --cached --name-only | grep -i ".svg\$"`
-do
- make nodecheck
- echo "Compressing $file"
- if [ -f $file ]; then
- node_modules/.bin/svgo "$file"
- git add "$file"
- else
- echo 'file was removed'
+ echo 'png was removed'
fi
done
--
To view, visit https://gerrit.wikimedia.org/r/107900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb5c97652b001e31f41cf2593a47a1bb4accc7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
