Legoktm has submitted this change and it was merged.
Change subject: Avoid using User::getSkin()
......................................................................
Avoid using User::getSkin()
Change-Id: I281bddd740cdf32b1342efabddb665274ee8c497
---
M JSBreadCrumbs.hooks.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Verified; Looks good to me, approved
diff --git a/JSBreadCrumbs.hooks.php b/JSBreadCrumbs.hooks.php
index fa47f7d..960665c 100644
--- a/JSBreadCrumbs.hooks.php
+++ b/JSBreadCrumbs.hooks.php
@@ -25,7 +25,7 @@
return true;
}
-
+
// Allow localized separator to be overriden
if ( $wgJSBreadCrumbsSeparator !== '' ) {
@@ -49,7 +49,7 @@
/**
* GetPreferences hook
- *
+ *
* Add module-releated items to the preferences
*/
public static function addPreferences( $user, $defaultPreferences ) {
@@ -78,11 +78,11 @@
}
static function enableBreadCrumbs() {
- global $wgUser;
+ global $wgOut, $wgUser;
// Ensure we only enable bread crumbs if we are using vector and
// the user has them enabled
- if ( $wgUser->getSkin() instanceof SkinVector &&
$wgUser->getOption( "jsbreadcrumbs-showcrumbs" ) ) {
+ if ( $wgOut->getSkin() instanceof SkinVector &&
$wgUser->getOption( "jsbreadcrumbs-showcrumbs" ) ) {
return true;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/106933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I281bddd740cdf32b1342efabddb665274ee8c497
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/JSBreadCrumbs
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
