jenkins-bot has submitted this change and it was merged.
Change subject: Anon users creating new header results in SQL error
......................................................................
Anon users creating new header results in SQL error
The SQL error complains that rc_user_text could not be null
Bug: 59638
Change-Id: I2eadb48bad64c94b34e079a0b4b5ac60ca020edd
---
M includes/Model/Header.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Model/Header.php b/includes/Model/Header.php
index 82d24d1..16cc79b 100644
--- a/includes/Model/Header.php
+++ b/includes/Model/Header.php
@@ -12,6 +12,9 @@
$obj->revId = UUID::create();
$obj->workflowId = $workflow->getId();
$obj->userId = $user->getId();
+ if ( !$user->getId() ) {
+ $obj->userIp = $user->getName();
+ }
$obj->userText = $user->getName();
$obj->prevRevision = null; // no prior revision
$obj->setContent( $content );
--
To view, visit https://gerrit.wikimedia.org/r/107757
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eadb48bad64c94b34e079a0b4b5ac60ca020edd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits