jenkins-bot has submitted this change and it was merged.
Change subject: Resize PhantomJS to 1280x1024 when the browser opens
......................................................................
Resize PhantomJS to 1280x1024 when the browser opens
By default PhantomJS uses 400x300 window size. That causes some tests
to fail because the window is to small. 1280x1024 would be a better
default size.
Bug: 60044
Change-Id: Ib331d703ce18bd6ade418107fed73a6a71d71fae
---
M lib/mediawiki/selenium/env.rb
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Manybubbles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/mediawiki/selenium/env.rb b/lib/mediawiki/selenium/env.rb
index 1e96f87..a6a122c 100644
--- a/lib/mediawiki/selenium/env.rb
+++ b/lib/mediawiki/selenium/env.rb
@@ -42,24 +42,27 @@
end
if language == "default"
- Watir::Browser.new browser_label
+ browser = Watir::Browser.new browser_label
else
if browser_label == :firefox
profile = Selenium::WebDriver::Firefox::Profile.new
profile["intl.accept_languages"] = language
- Watir::Browser.new browser_label, profile: profile
+ browser = Watir::Browser.new browser_label, profile: profile
elsif browser_label == :chrome
profile = Selenium::WebDriver::Chrome::Profile.new
profile["intl.accept_languages"] = language
- Watir::Browser.new browser_label, profile: profile
+ browser = Watir::Browser.new browser_label, profile: profile
elsif browser_label == :phantomjs
capabilities = Selenium::WebDriver::Remote::Capabilities.phantomjs
capabilities["phantomjs.page.customHeaders.Accept-Language"] = language
- Watir::Browser.new browser_label, desired_capabilities: capabilities
+ browser = Watir::Browser.new browser_label, desired_capabilities:
capabilities
else
raise "Changing default language is currently supported only for Chrome,
Firefox and PhantomJS!"
end
end
+
+ browser.window.resize_to 1280, 1024
+ browser
end
def sauce_api(json)
RestClient::Request.execute(
--
To view, visit https://gerrit.wikimedia.org/r/108025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib331d703ce18bd6ade418107fed73a6a71d71fae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jhall <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
