Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/108052
Change subject: api: Passthrough $data directly instead of copying by property
......................................................................
api: Passthrough $data directly instead of copying by property
* Prevent mistakes such as fixed by Ic5b42c4189.
* Expose the previously-suppressed Root#sets property.
Change-Id: I0d5bf9f7b742db8b49d0af23371389b0a4cdf7a4
---
M api/ApiTemplateData.php
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateData
refs/changes/52/108052/1
diff --git a/api/ApiTemplateData.php b/api/ApiTemplateData.php
index b6b2e5f..788f133 100644
--- a/api/ApiTemplateData.php
+++ b/api/ApiTemplateData.php
@@ -106,10 +106,7 @@
$resp[$row->pp_page] = array(
'title' => strval( $titles[$row->pp_page] ),
- 'description' => $data->description,
- 'params' => $data->params,
- 'paramOrder' => $data->paramOrder,
- );
+ ) + (array) $data;
}
// Set top level element
--
To view, visit https://gerrit.wikimedia.org/r/108052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d5bf9f7b742db8b49d0af23371389b0a4cdf7a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
