Bebirchall has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/108066


Change subject: Template failed fetches view in rt server
......................................................................

Template failed fetches view in rt server

Change-Id: I3d48f7fc00a77a5ccd0ca937f69e2d8374d01211
---
M tests/server/server.js
1 file changed, 20 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/66/108066/1

diff --git a/tests/server/server.js b/tests/server/server.js
index 454ba89..5dbd448 100755
--- a/tests/server/server.js
+++ b/tests/server/server.js
@@ -995,26 +995,28 @@
                        console.error( err );
                        res.send( err.toString(), 500 );
                } else {
-                       var n = rows.length;
-                       res.setHeader( 'Content-Type', 'text/html; 
charset=UTF-8' );
                        res.status( 200 );
-                       res.write( '<html><body>' );
-                       if (n === 0) {
-                               res.write('No titles returning 404!  All\'s 
well with the world!');
-                       } else {
-                               res.write('<h1> The following ' + n + ' titles 
return 404</h1>');
-                               res.write('<ul>');
-                               for (var i = 0; i < n; i++) {
-                                       var prefix = rows[i].prefix, title = 
rows[i].title;
-                                       var url = prefix.replace( /wiki$/, '' ) 
+ '.wikipedia.org/wiki/' + title;
-                                       var name = prefix + ':' + title;
-                                       res.write('<li><a href="http://' +
-                                                         
encodeURI(url).replace('&', '&amp;') + '">' +
-                                                         name.replace('&', 
'&amp;') + '</a></li>\n');
-                               }
-                               res.write( '</ul>');
+                       var n = rows.length;
+                       pageData = [];
+                       for (var i = 0; i < n; i++) {
+                               var prefix = rows[i].prefix, title = 
rows[i].title;
+                               var name = prefix + ':' + title;
+                               pageData.push({
+                                       url: prefix.replace( /wiki$/, '' ) + 
'.wikipedia.org/wiki/' + title;,
+                                       linkName: name.replace('&', '&amp;')
+                               });
                        }
-                       res.end('</body></html>' );
+                       var heading = n === 0 ? 'No titles returning 404!  
All\'s well with the world!' :
+                               'The following ' + n + ' titles return 404';
+                       var data = {
+                               alt: n === 0,
+                               heading: heading,
+                               items: pageData
+                       };
+                       hbs.registerHelper('formatUrl', function (url) {
+                               return 'http://' + encodeURI(url).replace('&', 
'&amp;');
+                       });
+                       res.render('list.html', data);
                }
        } );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/108066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d48f7fc00a77a5ccd0ca937f69e2d8374d01211
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Bebirchall <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to