jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Deprecate view (lowercase) module
......................................................................
Hygiene: Deprecate view (lowercase) module
Change-Id: I6b7d22e687d7e0510a5735cd2b49ef50a1357455
---
M javascripts/common/Drawer.js
M javascripts/common/Overlay.js
M javascripts/common/Page.js
M javascripts/common/View.js
M javascripts/modules/nearby/Nearby.js
M javascripts/modules/uploads/LeadPhoto.js
M javascripts/modules/uploads/PhotoUploaderButton.js
M javascripts/specials/mobileoptions.js
M javascripts/specials/uploads.js
M javascripts/widgets/progress-bar.js
M tests/javascripts/common/test_View.js
11 files changed, 11 insertions(+), 13 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/common/Drawer.js b/javascripts/common/Drawer.js
index 2457061..f7674bd 100644
--- a/javascripts/common/Drawer.js
+++ b/javascripts/common/Drawer.js
@@ -1,6 +1,6 @@
( function( M, $ ) {
-var View = M.require( 'view' ),
+var View = M.require( 'View' ),
Drawer;
/**
diff --git a/javascripts/common/Overlay.js b/javascripts/common/Overlay.js
index c7e4ec7..a9dd761 100644
--- a/javascripts/common/Overlay.js
+++ b/javascripts/common/Overlay.js
@@ -1,7 +1,7 @@
/*jshint unused:vars */
( function( M, $ ) {
-var View = M.require( 'view' ),
+var View = M.require( 'View' ),
Overlay;
/**
diff --git a/javascripts/common/Page.js b/javascripts/common/Page.js
index 2016c04..3e6c594 100644
--- a/javascripts/common/Page.js
+++ b/javascripts/common/Page.js
@@ -1,7 +1,7 @@
( function( M, $ ) {
var
- View = M.require( 'view' ),
+ View = M.require( 'View' ),
Section, Page;
/**
diff --git a/javascripts/common/View.js b/javascripts/common/View.js
index e281503..a198695 100644
--- a/javascripts/common/View.js
+++ b/javascripts/common/View.js
@@ -34,7 +34,7 @@
* @example
* // var View, Section, section;
* //
- * // View = M.require( 'view' );
+ * // View = M.require( 'View' );
* // Section = View.extend( {
* // template: M.template.compile(
'<h2>{{title}}</h2><p>{{text}}</p>' ),
* // // ...
@@ -187,8 +187,6 @@
};
} );
- // FIXME: Deprecate view
- M.define( 'view', View );
M.define( 'View', View );
}( mw.mobileFrontend, jQuery ) );
diff --git a/javascripts/modules/nearby/Nearby.js
b/javascripts/modules/nearby/Nearby.js
index 2c3b0df..4e5e3ea 100644
--- a/javascripts/modules/nearby/Nearby.js
+++ b/javascripts/modules/nearby/Nearby.js
@@ -1,6 +1,6 @@
( function( M, $ ) {
var NearbyApi = M.require( 'modules/nearby/NearbyApi' ),
- View = M.require( 'view' ),
+ View = M.require( 'View' ),
MobileWebClickTracking = M.require(
'loggingSchemas/MobileWebClickTracking' ),
LoadingOverlay = M.require( 'LoadingOverlay' ),
loader = new LoadingOverlay(),
diff --git a/javascripts/modules/uploads/LeadPhoto.js
b/javascripts/modules/uploads/LeadPhoto.js
index 2aed30c..5d01ca1 100644
--- a/javascripts/modules/uploads/LeadPhoto.js
+++ b/javascripts/modules/uploads/LeadPhoto.js
@@ -1,6 +1,6 @@
( function( M ) {
- var View = M.require( 'view' ), LeadPhoto;
+ var View = M.require( 'View' ), LeadPhoto;
LeadPhoto = View.extend( {
template: M.template.get( 'uploads/LeadPhoto' ),
diff --git a/javascripts/modules/uploads/PhotoUploaderButton.js
b/javascripts/modules/uploads/PhotoUploaderButton.js
index 7deb038..6cd4173 100644
--- a/javascripts/modules/uploads/PhotoUploaderButton.js
+++ b/javascripts/modules/uploads/PhotoUploaderButton.js
@@ -1,5 +1,5 @@
( function( M, $ ) {
- var View = M.require( 'view' ),
+ var View = M.require( 'View' ),
PhotoUploaderButton;
function isSupported() {
diff --git a/javascripts/specials/mobileoptions.js
b/javascripts/specials/mobileoptions.js
index 5301d43..8d34ebb 100644
--- a/javascripts/specials/mobileoptions.js
+++ b/javascripts/specials/mobileoptions.js
@@ -1,5 +1,5 @@
( function( M, $ ) {
- var View = M.require( 'view' ), Checkbox;
+ var View = M.require( 'View' ), Checkbox;
function supportsTouchEvents() {
return 'ontouchstart' in window;
diff --git a/javascripts/specials/uploads.js b/javascripts/specials/uploads.js
index 962f20e..c077aba 100644
--- a/javascripts/specials/uploads.js
+++ b/javascripts/specials/uploads.js
@@ -4,7 +4,7 @@
user = M.require( 'user' ),
popup = M.require( 'toast' ),
Api = M.require( 'api' ).Api,
- View = M.require( 'view' ),
+ View = M.require( 'View' ),
corsUrl = mw.config.get( 'wgMFPhotoUploadEndpoint' ),
pageParams = mw.config.get( 'wgPageName' ).split( '/' ),
currentUserName = user.getName(),
diff --git a/javascripts/widgets/progress-bar.js
b/javascripts/widgets/progress-bar.js
index b94f259..ad64dec 100644
--- a/javascripts/widgets/progress-bar.js
+++ b/javascripts/widgets/progress-bar.js
@@ -1,6 +1,6 @@
( function( M ) {
- var View = M.require( 'view' ), ProgressBar;
+ var View = M.require( 'View' ), ProgressBar;
ProgressBar = View.extend( {
className: 'progress-bar',
diff --git a/tests/javascripts/common/test_View.js
b/tests/javascripts/common/test_View.js
index 2442cdd..0b21579 100644
--- a/tests/javascripts/common/test_View.js
+++ b/tests/javascripts/common/test_View.js
@@ -1,6 +1,6 @@
( function( M, $ ) {
-var View = M.require( 'view' );
+var View = M.require( 'View' );
QUnit.module( 'MobileFrontend view' );
--
To view, visit https://gerrit.wikimedia.org/r/107300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b7d22e687d7e0510a5735cd2b49ef50a1357455
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
