Springle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/108310


Change subject: Disable dbstats slow query until better solution can be found.
......................................................................

Disable dbstats slow query until better solution can be found.

Change-Id: I88999365cffccf6e06490f99b1e01dcd31cae66c
---
M modules/mysql_wmf/files/ganglia/plugins/mysql.py
1 file changed, 11 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/10/108310/1

diff --git a/modules/mysql_wmf/files/ganglia/plugins/mysql.py 
b/modules/mysql_wmf/files/ganglia/plugins/mysql.py
index 9be9c20..4f610a9 100644
--- a/modules/mysql_wmf/files/ganglia/plugins/mysql.py
+++ b/modules/mysql_wmf/files/ganglia/plugins/mysql.py
@@ -120,15 +120,17 @@
 
                        # if the ganglia mysql users has been granted select 
access to an innodb table
                        # in the global space, this will report data_free for 
the global space.
-                       cursor = conn.cursor(MySQLdb.cursors.Cursor)
-                       cursor.execute('SELECT DATA_FREE FROM 
information_schema.TABLES WHERE ENGINE="InnoDB" LIMIT 1')
-                       ibdata_free = ""
-                       res = cursor.fetchone()
-                       if res:
-                               ibdata_free = res[0]
-                       else:
-                               ibdata_free = False
-                       cursor.close()
+                       #cursor = conn.cursor(MySQLdb.cursors.Cursor)
+                       # Disabled 2014-01-19 springle: too slow
+                       #cursor.execute('SELECT DATA_FREE FROM 
information_schema.TABLES WHERE ENGINE="InnoDB" LIMIT 1')
+                       #ibdata_free = ""
+                       #res = cursor.fetchone()
+                       #if res:
+                       #       ibdata_free = res[0]
+                       #else:
+                       #       ibdata_free = False
+                       #cursor.close()
+                       ibdata_free = False
 
                if get_master:
                        cursor = conn.cursor(MySQLdb.cursors.Cursor)

-- 
To view, visit https://gerrit.wikimedia.org/r/108310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88999365cffccf6e06490f99b1e01dcd31cae66c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Springle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to