Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/108534


Change subject: For IE, do not use salt for tofu detection
......................................................................

For IE, do not use salt for tofu detection

Adding salt wont work for IE since it uses a tofu with small width
for unassigned code points. From tests, Algortithm without salt
should be enough for IE.

Change-Id: If39e6c49d272fa67f60c19f1af64f1fb71856bcd
---
M resources/js/ext.uls.webfonts.js
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/34/108534/1

diff --git a/resources/js/ext.uls.webfonts.js b/resources/js/ext.uls.webfonts.js
index 30a41ec..d2a14f4 100644
--- a/resources/js/ext.uls.webfonts.js
+++ b/resources/js/ext.uls.webfonts.js
@@ -73,7 +73,10 @@
                        length = Math.min( 4, text.length ),
                        detected = false;
 
-               text = tofuSalt + text;
+               if ( $.client.test( { msie: false } ) ) {
+                       // IE shows a different tofu for unassigned code points!
+                       text = tofuSalt + text;
+               }
                $fixture = $( '<span>' )
                        .css( {
                                fontSize: '72px',

-- 
To view, visit https://gerrit.wikimedia.org/r/108534
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If39e6c49d272fa67f60c19f1af64f1fb71856bcd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to