Mdale has submitted this change and it was merged.
Change subject: Increase z-index on cannot play file warning
......................................................................
Increase z-index on cannot play file warning
This was causing the text in the warning to be unselectable, and
unclickable. Given that commons has links in that message, this
is a pretty severe usability issue.
See also Ifbe20df984 and bug 60243.
Change-Id: Ibd95d533b91f1f8b6bb9c983486e849c95005e8b
---
M MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Mdale: Verified; Looks good to me, approved
diff --git
a/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
b/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
index 0fabaeb..4ed2f81 100644
--- a/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
+++ b/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -1429,7 +1429,9 @@
'left' : '10px',
'right' : '10px',
'padding' : '4px',
- 'z-index' : 2
+ // z-index should be > than play button, as well as
greater
+ // than the dialog box (in pop up video), or link won't
work.
+ 'z-index' : '1502',
})
.html( warningMsg );
--
To view, visit https://gerrit.wikimedia.org/r/108631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd95d533b91f1f8b6bb9c983486e849c95005e8b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org>
Gerrit-Reviewer: Mdale <md...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
