Jhall has uploaded a new change for review. https://gerrit.wikimedia.org/r/108713
Change subject: [Browsertest] Test maintenance for new DOM elements. ...................................................................... [Browsertest] Test maintenance for new DOM elements. Change-Id: I25c1d98bd5cbee9ccb8d6fd1e2912e3205cf85ac --- M modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/13/108713/1 diff --git a/modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb b/modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb index 4ebf9b3..f405d1a 100644 --- a/modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb +++ b/modules/ve-mw/test/browser/features/step_definitions/bullets_steps.rb @@ -80,11 +80,11 @@ end Then(/^Decrease indentation should be disabled$/) do - on(VisualEditorPage).decrease_indentation_element.class_name.should match /disabled/ + on(VisualEditorPage).decrease_indentation_element.should be_visible end Then(/^Increase indentation should be disabled$/) do - on(VisualEditorPage).increase_indentation_element.class_name.should match /disabled/ + on(VisualEditorPage).increase_indentation_element.should be_visible end diff --git a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb index 57ef5ba..9f19aa3 100644 --- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb @@ -6,13 +6,14 @@ div(:container_disabled, class: "oo-ui-widget oo-ui-widget-disabled oo-ui-flaggableElement-constructive oo-ui-.oo-ui-buttonedElement-framed") div(:content, class: "ve-ce-documentNode ve-ce-branchNode") - span(:decrease_indentation, class: "oo-ui-widget oo-ui-tool oo-ui-tool-name-outdent oo-ui-widget-disabled") + span(:decrease_indentation, class: "oo-ui-widget oo-ui-tool oo-ui-tool-name-outdent oo-ui-iconedElement oo-ui-widget-disabled") a(:decrease_indentation_on, title: /Decrease indentation/) - span(:downarrow, class: "oo-ui-iconedElement-icon oo-ui-icon-down") + span(:downarrow, class: "oo-ui-indicatedElement-indicator oo-ui-indicator-down") a(:edit_ve, title: /Edit this page with VisualEditor/) a(:edit_wikitext, title: /You can edit this page\./) span(:heading, text: "Heading") - span(:increase_indentation, class: "oo-ui-widget oo-ui-tool oo-ui-tool-name-indent oo-ui-widget-disabled") + # span(:increase_indentation, class: "oo-ui-widget oo-ui-tool oo-ui-tool-name-indent oo-ui-widget-disabled") + span(:increase_indentation, class: "oo-ui-widget oo-ui-tool oo-ui-tool-name-indent oo-ui-iconedElement oo-ui-widget-disabled") a(:increase_indentation_on, title: /Increase indentation/) span(:insert_menu, text: "Insert") div(:insert_references, class: "oo-ui-window-title") -- To view, visit https://gerrit.wikimedia.org/r/108713 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I25c1d98bd5cbee9ccb8d6fd1e2912e3205cf85ac Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jhall <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
