Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/108720
Change subject: Fix up result of selectNodes to remove empty items
......................................................................
Fix up result of selectNodes to remove empty items
Bug: 60117
Change-Id: Ifa2ed0c1d315d78fdf7fbb6d13fca37e19445b1e
---
M modules/ve/dm/ve.dm.Document.js
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/20/108720/1
diff --git a/modules/ve/dm/ve.dm.Document.js b/modules/ve/dm/ve.dm.Document.js
index 08e8287..d4298df 100644
--- a/modules/ve/dm/ve.dm.Document.js
+++ b/modules/ve/dm/ve.dm.Document.js
@@ -381,6 +381,18 @@
contextOpenings = [],
contextClosings = [];
+ // Fix up selection to remove empty items
+ // TODO: fix selectNodes
+ while ( selection[0] && selection[0].range &&
selection[0].range.isCollapsed() ) {
+ selection.shift();
+ }
+
+ i = selection.length - 1;
+ while ( selection[i] && selection[i].range &&
selection[i].range.isCollapsed() ) {
+ selection.pop();
+ i--;
+ }
+
if ( selection.length === 0 ) {
// Nothing selected
data = new ve.dm.ElementLinearData( this.getStore(), [] );
--
To view, visit https://gerrit.wikimedia.org/r/108720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa2ed0c1d315d78fdf7fbb6d13fca37e19445b1e
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
