Ori.livneh has submitted this change and it was merged.

Change subject: webperf: fix-up for navtiming.py bug
......................................................................


webperf: fix-up for navtiming.py bug

Follows If0dbb52ca30

Change-Id: I2052a1a0e5b5a88f55873028f6007c524cfd1c82
---
M modules/webperf/files/navtiming.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved



diff --git a/modules/webperf/files/navtiming.py 
b/modules/webperf/files/navtiming.py
index 74c58de..87642c1 100644
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -27,6 +27,9 @@
 
 args = ap.parse_args()
 
+logging.basicConfig(format='%(asctime)-15s %(message)s', level=logging.INFO,
+                    stream=sys.stdout)
+
 ctx = zmq.Context()
 zsock = ctx.socket(zmq.SUB)
 zsock.hwm = 3000
@@ -41,11 +44,11 @@
 def dispatch_stat(*args):
     if len(args) < 2:
         raise ArgumentError
+    args = list(args)
     value = args.pop()
     name = '.'.join([prefix] + args)
     stat = '%s:%s|ms' % (name, value)
     sock.sendto(stat.encode('utf-8'), addr)
-    logging.info(stat)
 
 
 for meta in iter(zsock.recv_json, ''):
@@ -82,6 +85,4 @@
     for metric in metrics:
         value = event.get(metric, 0)
         if value > 0 and value < 60000:
-            dispatch_stat(metric, site, value)
             dispatch_stat(metric, site, auth, value)
-            dispatch_stat(metric, bits_cache, value)

-- 
To view, visit https://gerrit.wikimedia.org/r/108891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2052a1a0e5b5a88f55873028f6007c524cfd1c82
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to