Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/108916
Change subject: Replaced sleep with page-object gem waiting API
......................................................................
Replaced sleep with page-object gem waiting API
Bug: 46887
Change-Id: I73a3007a58ac47e71ecdff5c0eb6aa1f5c2e0d90
---
M features/step_definitions/print_export_menu_steps.rb
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests
refs/changes/16/108916/1
diff --git a/features/step_definitions/print_export_menu_steps.rb
b/features/step_definitions/print_export_menu_steps.rb
index ece84c4..02d008a 100644
--- a/features/step_definitions/print_export_menu_steps.rb
+++ b/features/step_definitions/print_export_menu_steps.rb
@@ -11,8 +11,7 @@
#
Then(/^Print\/export section should be collapsed$/) do
on(RandomPage) do |page|
- sleep 1
- page.create_a_book_element.should_not be_visible
+ page.create_a_book_element.when_not_visible.should_not be_visible
page.download_as_pdf_element.should_not be_visible
page.printable_version_element.should_not be_visible
end
--
To view, visit https://gerrit.wikimedia.org/r/108916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73a3007a58ac47e71ecdff5c0eb6aa1f5c2e0d90
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
