jenkins-bot has submitted this change and it was merged.
Change subject: Removed sleep with waiting API in browsertests
......................................................................
Removed sleep with waiting API in browsertests
Bug: 46887
Change-Id: I92b464fc5a7016cab093de8085a6cfb6bc7dc4a8
---
M features/step_definitions/print_export_menu_steps.rb
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
Zfilipin: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/features/step_definitions/print_export_menu_steps.rb
b/features/step_definitions/print_export_menu_steps.rb
index ece84c4..cbfe071 100644
--- a/features/step_definitions/print_export_menu_steps.rb
+++ b/features/step_definitions/print_export_menu_steps.rb
@@ -20,8 +20,7 @@
Then(/^Print\/export section should be expanded$/) do
on(RandomPage) do |page|
- sleep 1
- page.create_a_book_element.should be_visible
+ page.create_a_book_element.when_visible.should be_visible
page.download_as_pdf_element.should be_visible
page.printable_version_element.should be_visible
end
--
To view, visit https://gerrit.wikimedia.org/r/108918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92b464fc5a7016cab093de8085a6cfb6bc7dc4a8
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jhall <[email protected]>
Gerrit-Reviewer: Mayankmadan <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
