jenkins-bot has submitted this change and it was merged.
Change subject: QA: Merge user_login and login pages
......................................................................
QA: Merge user_login and login pages
They are the same and having two is confusing
Use more established login page
Change-Id: I44f2a6d8eeda4ac922c247ac274e9f19c33dded9
---
M
tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
M tests/browser/features/support/pages/login_page.rb
D tests/browser/features/support/pages/user_login_page.rb
3 files changed, 3 insertions(+), 17 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
b/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
index 0f77692..e6a8908 100644
---
a/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
+++
b/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
@@ -1,9 +1,9 @@
Given(/^that I am on the User login page$/) do
- visit(UserLoginPage)
+ visit(LoginPage)
end
Given(/^I click Create Account$/) do
- on(UserLoginPage).create_account_link_element.when_present.click
+ on(LoginPage).create_account_link_element.when_present.click
end
Given(/^I type (.+) into Username field$/) do |username|
diff --git a/tests/browser/features/support/pages/login_page.rb
b/tests/browser/features/support/pages/login_page.rb
index 3cf956c..fb5da2b 100644
--- a/tests/browser/features/support/pages/login_page.rb
+++ b/tests/browser/features/support/pages/login_page.rb
@@ -14,6 +14,7 @@
text_field(:username, id: "wpName1")
a(:login_wl, class: "button")
button(:signup_submit, id:"wpCreateaccount")
+ a(:create_account_link, text: "Create account")
def logged_in_as_element
@browser.div(id: "mw-content-text").p.b
@@ -24,5 +25,3 @@
login
end
end
-
-
diff --git a/tests/browser/features/support/pages/user_login_page.rb
b/tests/browser/features/support/pages/user_login_page.rb
deleted file mode 100644
index 7a4b9dc..0000000
--- a/tests/browser/features/support/pages/user_login_page.rb
+++ /dev/null
@@ -1,13 +0,0 @@
-class UserLoginPage
- include PageObject
-
- include URL
- def self.url
- URL.url("Special:UserLogin")
- end
- page_url url
-
- text_field(:username_field, id: "wpName1")
- text_field(:password_field, id: "wpPassword2")
- a(:create_account_link, text: "Create account")
-end
--
To view, visit https://gerrit.wikimedia.org/r/109097
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44f2a6d8eeda4ac922c247ac274e9f19c33dded9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
