jenkins-bot has submitted this change and it was merged.
Change subject: QA: Fix tests breaking due to I am on the home page step
......................................................................
QA: Fix tests breaking due to I am on the home page step
Make it a given rather than a when as it is not really part of the
test itself
Change-Id: I4675ac5947c1e6e34aa180830f006f7de5716e29
---
M tests/browser/features/language_logged_in.feature
M tests/browser/features/step_definitions/common_steps.rb
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/language_logged_in.feature
b/tests/browser/features/language_logged_in.feature
index 2f63e18..64482f9 100644
--- a/tests/browser/features/language_logged_in.feature
+++ b/tests/browser/features/language_logged_in.feature
@@ -3,8 +3,8 @@
Background:
Given I am logged into the mobile website
+ And I am on the home page
Scenario: Validate Language selection availability
- When I am on the home page
- And I click the language button
- Then I move to the language screen
+ When I click the language button
+ Then I see the language overlay
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 79cc704..5051868 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -61,8 +61,8 @@
on(NonexistentPage).current_url.should eq NonexistentPage.url
end
-Then(/^I am on the home page$/) do
- on(HomePage).current_url.should eq HomePage.url
+When(/^I am on the home page$/) do
+ visit(HomePage)
end
When(/^I click the browser back button$/) do
--
To view, visit https://gerrit.wikimedia.org/r/109099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4675ac5947c1e6e34aa180830f006f7de5716e29
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
