jenkins-bot has submitted this change and it was merged.
Change subject: Fix order of assertEquals params
......................................................................
Fix order of assertEquals params
"Failed asserting that <2nd arg> matches expected <1st arg>."
The fail message was slightly confusing with the arguments reversed.
Change-Id: I8f04b9e9fb4f25e9aa530811eb22e28496728e78
---
M tests/AbuseFilterTest.php
M tests/PostRevisionTest.php
M tests/SpamBlacklistTest.php
M tests/SpamRegexTest.php
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Werdna: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/AbuseFilterTest.php b/tests/AbuseFilterTest.php
index 64302f8..af5411a 100644
--- a/tests/AbuseFilterTest.php
+++ b/tests/AbuseFilterTest.php
@@ -51,7 +51,7 @@
$title = Title::newFromText( 'UTPage' );
$status = $this->spamFilter->validate( $newRevision,
$oldRevision, $title );
- $this->assertEquals( $status->isOK(), $expected );
+ $this->assertEquals( $expected, $status->isOK() );
}
protected function setUp() {
diff --git a/tests/PostRevisionTest.php b/tests/PostRevisionTest.php
index 6f8130a..e97d337 100644
--- a/tests/PostRevisionTest.php
+++ b/tests/PostRevisionTest.php
@@ -20,6 +20,6 @@
$roundtripRow = PostRevision::toStorageRow( $object );
unset( $roundtripRow['rev_content_url'] );
- $this->assertEquals( $roundtripRow, $row );
+ $this->assertEquals( $row, $roundtripRow );
}
}
diff --git a/tests/SpamBlacklistTest.php b/tests/SpamBlacklistTest.php
index c94e013..a3e41bb 100644
--- a/tests/SpamBlacklistTest.php
+++ b/tests/SpamBlacklistTest.php
@@ -55,7 +55,7 @@
$title = Title::newFromText( 'UTPage' );
$status = $this->spamFilter->validate( $newRevision,
$oldRevision, $title );
- $this->assertEquals( $status->isOK(), $expected );
+ $this->assertEquals( $expected, $status->isOK() );
}
protected function setUp() {
diff --git a/tests/SpamRegexTest.php b/tests/SpamRegexTest.php
index e065248..d884fe1 100644
--- a/tests/SpamRegexTest.php
+++ b/tests/SpamRegexTest.php
@@ -36,7 +36,7 @@
$title = Title::newFromText( 'UTPage' );
$status = $this->spamFilter->validate( $newRevision,
$oldRevision, $title );
- $this->assertEquals( $status->isOK(), $expected );
+ $this->assertEquals( $expected, $status->isOK() );
}
protected function setUp() {
--
To view, visit https://gerrit.wikimedia.org/r/109087
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f04b9e9fb4f25e9aa530811eb22e28496728e78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: Werdna <agarr...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
