Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/109447
Change subject: Add ext.uls.messages as dependency for ext.uls.mediawiki
......................................................................
Add ext.uls.messages as dependency for ext.uls.mediawiki
Turns out the messages for language selector were not loading
in Special:MainPage. This fixes that as well as cleaning up the
dependencies.
Change-Id: Ice8dcf1b2e878a0fe3cd0e002a9b1cff2f1901dd
---
M Resources.php
M resources/js/ext.uls.interface.js
2 files changed, 8 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/47/109447/1
diff --git a/Resources.php b/Resources.php
index b06a8f1..1557eb4 100644
--- a/Resources.php
+++ b/Resources.php
@@ -201,14 +201,18 @@
'styles' => 'lib/jquery.ime/css/jquery.ime.css',
) + $resourcePaths;
-// A module that sets useful ULS default options
+// This module sets default options for the language selector that are
+// suitable for MediaWiki and loads necessary dependencies like grid,
+// messages and jquery.uls itself.
$wgResourceModules['ext.uls.mediawiki'] = array(
'scripts' => 'resources/js/ext.uls.mediawiki.js',
'dependencies' => array(
- 'jquery.uls',
- 'mediawiki.util',
'ext.uls.init',
'ext.uls.languagenames',
+ 'ext.uls.messages',
+ 'jquery.uls',
+ 'jquery.uls.grid',
+ 'mediawiki.util',
),
) + $resourcePaths;
diff --git a/resources/js/ext.uls.interface.js
b/resources/js/ext.uls.interface.js
index 11706a0..c6b61f2 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -421,7 +421,7 @@
mw.hook(
'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal'
);
}
} else {
- mw.loader.using(
['ext.uls.mediawiki', 'jquery.uls.grid'], function () {
+ mw.loader.using(
'ext.uls.mediawiki', function () {
$ulsTrigger.uls( {
quickList:
function () {
return
mw.uls.getFrequentLanguageList();
--
To view, visit https://gerrit.wikimedia.org/r/109447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice8dcf1b2e878a0fe3cd0e002a9b1cff2f1901dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
