jenkins-bot has submitted this change and it was merged.
Change subject: Removed sleep variable from TwnMainPage tests
......................................................................
Removed sleep variable from TwnMainPage tests
Removed sleep variable from signed_in_and_approved feature.
Added a timout(10) because sometimes it can take more than 5s
Bug: 46887
Change-Id: Ia96d6a34e03ee0f6fd4c941d19ee729582ec8d46
---
M tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
Zfilipin: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git
a/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb
b/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb
index bded465..61338b4 100644
---
a/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb
+++
b/tests/browser/features/step_definitions/signed_in_and_approved_user_steps.rb
@@ -63,8 +63,7 @@
When(/^I click a message group$/) do
# The message groups load very slow, it should be speed up
- sleep 5;
- on(MainPage).message_group_row_element.when_visible.click
+ on(MainPage).message_group_row_element.when_visible(10).click
end
When(/^I search for "(.*?)"$/) do |query|
--
To view, visit https://gerrit.wikimedia.org/r/109471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96d6a34e03ee0f6fd4c941d19ee729582ec8d46
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Mayankmadan <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
